[
https://issues.apache.org/jira/browse/MPATCH-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16681058#comment-16681058
]
ASF GitHub Bot commented on MPATCH-20:
--------------------------------------
rfscholte commented on a change in pull request #2: added support for
excludePattern (fixes MPATCH-20)
URL: https://github.com/apache/maven-patch-plugin/pull/2#discussion_r232173205
##########
File path: src/main/java/org/apache/maven/plugin/patch/ApplyMojo.java
##########
@@ -237,6 +238,16 @@
@Parameter( defaultValue = "false" )
private boolean binary;
+ /**
+ * List of ANT-style exclude patterns. These patterns are used to exclude
patch files found
+ * in the {@link ApplyMojo#patchDirectory}. These exclude patterns does
not apply to a static defined list of
+ * {@link ApplyMojo#patches}.
+ *
+ * @since 1.3
+ */
+ @Parameter
+ private List excludes;
Review comment:
AFAIK this plugin was written in Java 1.4, not a lot of maintenance so
nobody cared about generics. However we should, especially when adding new code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> support exclude pattern
> -----------------------
>
> Key: MPATCH-20
> URL: https://issues.apache.org/jira/browse/MPATCH-20
> Project: Maven Patch Plugin
> Issue Type: New Feature
> Affects Versions: 1.2, 1.3
> Reporter: Matthias Balke
> Priority: Major
>
> The maven-patch-plugin should provide a feature to configure an exclude
> pattern which is applied, when searching for patch files within
> {{patchDirectory}}.
>
> I'll provide a PR on GitHub for this feature.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
