[ 
https://issues.apache.org/jira/browse/MSHADE-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16668353#comment-16668353
 ] 

ASF GitHub Bot commented on MSHADE-303:
---------------------------------------

danilcha opened a new pull request #8: [MSHADE-303] Suppress module-info.class 
warning if the file if filtered
URL: https://github.com/apache/maven-shade-plugin/pull/8
 
 
   Maven always shows “Discovered module-info.class. Shading will break its 
strong encapsulation.” warning, even then the user has explicitly filtered 
those files out. The same with “META-INF/INDEX.LIST” file. 
   
   This pull request fixes this by applying file filters BEFORE these built-in 
warning checkers. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Suppress module-info.class warning if the file if filtered
> ----------------------------------------------------------
>
>                 Key: MSHADE-303
>                 URL: https://issues.apache.org/jira/browse/MSHADE-303
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: Danila
>            Priority: Major
>
> Maven always shows “Discovered module-info.class. Shading will break its 
> strong encapsulation.” warning, even then the user has explicitly filtered 
> those files out. The same with “META-INF/INDEX.LIST” file.
> I am going to issue a pull request to fix this by applying file filters 
> BEFORE these built-in warning checkers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to