[
https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663309#comment-16663309
]
ASF GitHub Bot commented on SUREFIRE-1585:
------------------------------------------
Tibor17 commented on a change in pull request #196: [SUREFIRE-1585] [WIP]
Resolve missing artifact
URL: https://github.com/apache/maven-surefire/pull/196#discussion_r228045641
##########
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/TestClassPath.java
##########
@@ -69,9 +70,9 @@ void avoidArtifactDuplicates( Set<Artifact>
providerArtifacts )
&& ( classifier1 == null ? classifier2 == null :
classifier1.equals( classifier2 ) ) )
{
it.remove();
- if ( logger.isDebugEnabled() )
+ if ( mojo != null && mojo.getLog().isDebugEnabled() )
Review comment:
I have only several problems with this class:
1. We have AbstractSurefireMojo here.
2. We know what provider is being executed. What about to add a boolean to
this method `isPlatformPrvicer` or enum instead of using null-checks in `if (
junitJupiterApi != null && junitJupiterEngine == null )`.
3. Why we do not align the versions of `junit-platform-launcher` dependency
of our provider in classpath according to user's dependency version as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Auto-resolve "missing" artifacts
> --------------------------------
>
> Key: SUREFIRE-1585
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1585
> Project: Maven Surefire
> Issue Type: Improvement
> Components: JUnit 5.x support
> Affects Versions: 2.22.1
> Reporter: Christian Stein
> Assignee: Christian Stein
> Priority: Minor
> Labels: features
>
> Providers should be able to enhance the test runtime by injecting "missing"
> artifacts before executing tests.
>
> For example, the JUnit Platform Provider should add "missing" Test Engine
> artifacts for when users only depend on the API of a test framework.
> * User test depends on *`junit-jupiter-api`* only? Provide
> *`junit-jupiter-engine`* at test runtime -- automatically or via plugin deps.
> * User test depends on *`junit-jupiter-params`* only? That pulls in
> *`junit-jupiter-api`* transitively. Provide *`junit-jupiter-engine`* at test
> runtime -- automatically or via plugin deps.
> * User test depends on *`junit:junit:4.12`* only *AND* the JUnit Platform
> Provider is forced? Provide *`junit-vintage-engine`* at test runtime --
> automatically or via plugin deps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)