[ 
https://issues.apache.org/jira/browse/MJLINK-27?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634564#comment-16634564
 ] 

Karl Heinz Marbaise commented on MJLINK-27:
-------------------------------------------

So based on what I've read in the [http://openjdk.java.net/jeps/261] which is 
the following (quote from the JEP261):
{quote}When searching a module path for a module of a particular name, the 
module system takes the first definition of a module of that name. Version 
strings, if present, are ignored; if an element of a module path contains 
definitions of multiple modules with the same name then resolution fails and 
the compiler, linker, or virtual machine will report an error and exit. It is 
the responsibility of build tools and container applications to configure 
module paths so as to avoid version conflicts; it is not a goal of the module 
system to address the version-selection problem.
{quote}
I would like to emphasize the following:
{quote}if an element of a module path contains definitions of multiple modules 
with the same name then resolution fails and the compiler, linker, or virtual 
machine will report an error and exit.{quote}


> Code incorrectly assumes that two modules won't have the same name
> ------------------------------------------------------------------
>
>                 Key: MJLINK-27
>                 URL: https://issues.apache.org/jira/browse/MJLINK-27
>             Project: Maven JLink Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0-alpha-2
>            Reporter: Gili
>            Priority: Major
>
> Karl Heinz Marbaise closed MJLINK-7 referencing [a Stackoverflow 
> post|https://stackoverflow.com/questions/46573572/java-9-possible-to-have-2-modules-with-same-name-on-module-path/46574200#46574200]
>  to prove that module names must be unique. In fact, this Stackoverflow post 
> says the exact opposite. The bottom half of the post states that modules in 
> separate directories **are** allowed to have the same name. The bottom of the 
> post concludes:
> {quote}That makes it possible to have the same module in different 
> directories.
> {quote}
> It doesn't have to be the same module per-se. It is possible for two 
> different implementations with the same module name to reside on the module 
> path, so long as the modules reside in different directory. This is useful 
> for "class shadowing". In my particular case, I ship a no-op implementation 
> of a module by default but users can insert a working implementation in front 
> of the module path to enable the feature.
> Please reopen this issue or continue its work here.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to