[
https://issues.apache.org/jira/browse/MRESOLVER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627834#comment-16627834
]
ASF GitHub Bot commented on MRESOLVER-7:
----------------------------------------
michael-o commented on a change in pull request #10: [MRESOLVER-7] Download
dependency POMs in parallel v2
URL: https://github.com/apache/maven-resolver/pull/10#discussion_r220323542
##########
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -91,6 +98,13 @@
private VersionRangeResolver versionRangeResolver;
+ private static final ThreadGroup THREAD_GROUP = new ThreadGroup( "Maven
Resolver dependency resolution" );
+
+ /**
+ * Setup executor with 5 daemon threads in pool, max to 10 concurrent and
keep alive to 10 sec inactivity.
+ */
+ private ExecutorService executor = createExecutorService( 5, 10, 10 );
Review comment:
Last arg is `10L`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Download dependency POMs in parallel
> ------------------------------------
>
> Key: MRESOLVER-7
> URL: https://issues.apache.org/jira/browse/MRESOLVER-7
> Project: Maven Resolver
> Issue Type: Improvement
> Affects Versions: Aether 1.0.2
> Reporter: Harald Wellmann
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 1.1.2
>
>
> h3. Background
> When building a project with dependencies not yet available in the local
> repository, I noticed that Maven 3.3.9/Aether 1.0.2 first downloads the
> dependency POMs _sequentially_ and then proceeds downloading the dependency
> JARs with up to 5 threads _in parallel_.
> Due to this, when first building a project with a large number of
> dependencies, downloading a large number of small POMs may take a lot longer
> than downloading the much larger JARs, or even longer than building the
> project itself, especially when a repository manager is used which increases
> the download latency.
> h3. Enhancement
> Download POMs of (transitive) dependencies in parallel to significantly speed
> up initial builds of large projects.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
