[ http://jira.codehaus.org/browse/MPMD-28?page=comments#action_79461 ] Mike Perham commented on MPMD-28: ---------------------------------
Damien, I decided to look at this real quick once I decided I didn't have enough time. :-) I can't apply your patch for two reasons, both of which should be easy for you to fix: 1) No documentatiion about the new feature. Any time you add a new feature, you need to document what it is and how it works. 2) The patched code violates the maven coding style in a number of locations. Please make sure your code blends in well with the existing code. There are Eclipse and IDEA settings files on this page: http://maven.apache.org/guides/development/guide-m2-development.html 3) No tests. This isn't absolutely required but dramatically increase the likelihood of patch acceptance since it's usually a good sign you are a thorough developer. Please feel free to submit an updated patch and I will try to iterate on it quicker this time. > Support for multi-projects poms > ------------------------------- > > Key: MPMD-28 > URL: http://jira.codehaus.org/browse/MPMD-28 > Project: Maven 2.x Pmd Plugin > Issue Type: Improvement > Reporter: Torsten Curdt > Attachments: maven-pmd-plugin-20061020-1242.patch, > maven-pmd-plugin-20061020-1445.patch, multiproject.diff > > > Added support for multi-projects so if you set "aggregate" to "true" the > parent project will generate the report and the childs will not execute it > anymore -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
