[ http://jira.codehaus.org/browse/MRELEASE-160?page=all ]

Tom Parker updated MRELEASE-160:
--------------------------------

    Attachment: PomRewriteVersions.patch

Description for PomRewriteVersions.patch.

Fix for this issue.  I have not tested this patch without first applying 
dryRun.patch.

The actual fix is in 
org.apache.maven.shared.release.phase.AbstractRewritePomsPhase. I don't fully 
understand this class, so I may have overlooked something.

Included are 3 new testcases:

org.apache.maven.shared.release.phase.RewritePomsForDevelopmentPhaseTest.testRewriteComplexSnapshotDependancies
confirms that the existing test rewrite-poms-for-release and 
rewrite-poms-for-development tests are insuffient. This test may be redundent 
-- I didn't do a full audit of the existing tests to see if this case is 
catered for.

org.apache.maven.shared.release.phase.RewritePomsForReleaseAndDevelopmentPhasesTest.testComplexSnapshotDependancies
 checks the situation outlined in this issue.

org.apache.maven.shared.release.phase.RewritePomsForReleaseAndDevelopmentPhasesTest.testSimulateComplexSnapshotDependancies
 the same as testComplexSnapshotDependancies but using the dryRun option.

I had to move a method from AbstractRewritingReleasePhaseTestCase to 
AbstractReleaseTestCase in order to access it from 
RewritePomsForReleaseAndDevelopmentPhasesTest.

> The next snapshot version is not used un submodules
> ---------------------------------------------------
>
>                 Key: MRELEASE-160
>                 URL: http://jira.codehaus.org/browse/MRELEASE-160
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>    Affects Versions: 2.0-beta-4
>            Reporter: Joerg Schaible
>         Attachments: dryRun.patch, PomRewriteVersions.patch
>
>
> In multi-module mode the release plugin replaces the version of snapshot 
> dependencies in the submodules automatically for dependencies that are also 
> part of the release. But this versions are not set to the next version after 
> the release process. E.g. in a module with two submodules (one EJB and an EAR 
> depedning on this EJB) the EJB depednency is added with a SNAPSHOT 
> depednecny. At release time the plugin replaces this version with the version 
> used for the release. After the release the version tag in the parent section 
> of both POMs are set to the next version, but the verison in the EARs 
> depednency stays at the release. This is higly error-prone, since with the 
> next release the EAR still references the old version of the EJB.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to