forax commented on issue #14: [MPLUGIN-336] Upgrade ASM to 6.2 for Java 10,11 
support
URL: https://github.com/apache/maven-plugin-tools/pull/14#issuecomment-416558641
 
 
   The ClassReader reads a class attribute named NestHost because javac 11 now 
emits such attribute, but because the mojoClassVisitor is configured with ASM6 
(at construction) it fails because ASM knows that the visitor doesn't handle 
such attribute.
   
   ASM doesn't let a visitor ignore nest mate attributes because those 
attributes enable/disable access to private members from an inner class, so if 
by default the visitor ignore this attribute you will get weird 
IllegalAccessError later at runtime.
   
   So the implementer of the mojo visitor has to decide if it's ok to just 
enabling ASM7_EXPERIMENTAL and if the methods visitNestHostExperimental() and 
visitNestMembersExperimental have to be implemented. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to