[
https://issues.apache.org/jira/browse/MSHARED-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16560172#comment-16560172
]
ASF GitHub Bot commented on MSHARED-750:
----------------------------------------
KathrynN commented on a change in pull request #4: [MSHARED-750] - Unbalanced
quotes in command with escaped double quot…
URL: https://github.com/apache/maven-shared-utils/pull/4#discussion_r205876736
##########
File path:
src/main/java/org/apache/maven/shared/utils/cli/CommandLineUtils.java
##########
@@ -490,31 +491,65 @@ private static boolean isAlive( Process p )
case inQuote:
if ( "\'".equals( nextTok ) )
{
- state = normal;
+ if ( inEscape )
+ {
+ current.append( nextTok );
+ inEscape = false;
+ }
+ else
+ {
+ state = normal;
+ }
}
else
{
current.append( nextTok );
+ inEscape = "\\".equals( nextTok );
}
break;
case inDoubleQuote:
if ( "\"".equals( nextTok ) )
{
- state = normal;
+ if ( inEscape )
+ {
+ current.append( nextTok );
+ inEscape = false;
+ }
+ else
+ {
+ state = normal;
+ }
}
else
{
current.append( nextTok );
+ inEscape = "\\".equals( nextTok );
}
break;
default:
if ( "\'".equals( nextTok ) )
{
- state = inQuote;
+ if ( inEscape )
+ {
+ inEscape = false;
+ current.append( nextTok );
+ }
+ else
+ {
+ state = inQuote;
+ }
}
else if ( "\"".equals( nextTok ) )
{
- state = inDoubleQuote;
+ if ( inEscape )
Review comment:
If anyone has a tidier way to do this, it would be much appreciated!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Unbalanced quotes in command with escaped double quotation mark
> ---------------------------------------------------------------
>
> Key: MSHARED-750
> URL: https://issues.apache.org/jira/browse/MSHARED-750
> Project: Maven Shared Components
> Issue Type: Bug
> Reporter: Kathryn Newbould
> Priority: Major
>
> Due to [MSHARED_749], the following test will error (due to an exception
> being thrown) in master maven:
> {code:java}
> @Test
> public void
> givenAnEscapedDoubleQuoteMarkInArgument_whenPreparingToExecuteCode_thenTheQuotationMarkRemainsEscaped()
> throws Exception {
> final String command = "echo \"let\\\"s go\"";
> final String[] actual = CommandLineUtils.translateCommandline(command);
> final String[] expected = new String[]{"echo", "let\\\"s go"};
> assertArrayEquals(expected, actual);
> }
> {code}
> Results:
> {code:java}
> org.apache.maven.shared.utils.cli.CommandLineException: unbalanced quotes in
> echo "let\"s go"{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
