[
https://issues.apache.org/jira/browse/MNG-6432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520726#comment-16520726
]
Michael Osipov edited comment on MNG-6432 at 6/22/18 7:50 PM:
--------------------------------------------------------------
I do not really see a bug here. The documentation says
bq. The position of wildcards within a comma separated list of repository
identifiers is not important as the wildcards defer to further processing and
explicit includes or excludes stop the processing, overruling any wildcard
match.
Nothing about leading or trailing whitespace. What do you expect to see? Code
in question is in:
{{org.apache.maven.repository.DefaultMirrorSelector.matchPattern(ArtifactRepository,
String)}}.
was (Author: michael-o):
I do not really see a bug here. The documentation says
bq. The position of wildcards within a comma separated list of repository
identifiers is not important as the wildcards defer to further processing and
explicit includes or excludes stop the processing, overruling any wildcard
match.
Nothing about leading or trailing whitespace.
> Space in <mirrorOf /> silently disables mirror
> ----------------------------------------------
>
> Key: MNG-6432
> URL: https://issues.apache.org/jira/browse/MNG-6432
> Project: Maven
> Issue Type: Bug
> Components: Settings
> Affects Versions: 3.0.5, 3.3.9, 3.5.2
> Environment: Maven 3.5.2 (Red Hat 3.5.2-5 on Fedora 28).
> and
> Maven 3.0.5 (Red Hat 3.0.5-17 on RHEL 7.5)
> and
> Maven 3.3.9 on RHEL 7.5
> Reporter: Elias Elmqvist Wulcan
> Priority: Minor
> Labels: newbie
>
>
> Maven silently ignores mirror configuration when there is a space in
> mirrorOf. This could be a major problem if the developer's mirror
> configuration is critical and this causes her to not notice that the mirror
> is disabled.
> Without space inside mirrorOf, the mirror setting is respected.
> {code:java}
> <settings>
> <mirrors>
> <mirror>
> <id>loopback</id>
> <name>loopback</name>
> <url>http://127.0.0.1</url>
> <mirrorOf>!my-repo,*</mirrorOf>
> </mirror>
> </mirrors>
> </settings>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building mirrorOf-test 1
> [INFO]
> ------------------------------------------------------------------------
> Downloading from loopback:
> http://127.0.0.1/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> {noformat}
>
> With a space after the comma in mirrorOf, the mirror is ignored without
> warning.
> {code:java}
> <settings>
> <mirrors>
> <mirror>
> <id>loopback</id>
> <name>loopback</name>
> <url>http://127.0.0.1</url>
> <mirrorOf>!my-repo, *</mirrorOf>
> </mirror>
> </mirrors>
> </settings>
> {code}
> {noformat}
> [INFO] Scanning for projects...
> [INFO]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Building mirrorOf-test 1
> [INFO]
> ------------------------------------------------------------------------
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/plugins/maven-clean-plugin/2.5/maven-clean-plugin-2.5.pom
> ...
> {noformat}
>
> The problem is reproducible with minimal pom.xm
> {code:java}
> <project>
> <modelVersion>4.0.0</modelVersion>
> <groupId>com.example</groupId>
> <artifactId>mirrorOf-test</artifactId>
> <version>1</version>
> </project>
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
