[
https://issues.apache.org/jira/browse/SUREFIRE-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434604#comment-16434604
]
ASF GitHub Bot commented on SUREFIRE-1454:
------------------------------------------
Tibor17 commented on a change in pull request #180: SUREFIRE-1454 fix for empty
array
URL: https://github.com/apache/maven-surefire/pull/180#discussion_r180906907
##########
File path:
surefire-api/src/test/java/org/apache/maven/surefire/util/internal/StringUtilsTest.java
##########
@@ -110,4 +110,12 @@ public void testEscapeWithHeader()
assertArrayEquals( expectedResult, actualResult );
}
+
+ public void testEmptyByteArray() {
Review comment:
Pls put the bracket '{' on new line as we have in other main code.
Amend the previous commit means we should have single commit per
fix/feature. Thx.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Speedup Standard Output if Tests
> --------------------------------
>
> Key: SUREFIRE-1454
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1454
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
> Reporter: Tibor Digana
> Assignee: Tibor Digana
> Priority: Major
> Fix For: 2.21.0
>
>
> Currently, surefire creates a new byte array with size of the input *3 for
> saving the unescaped input. This made surefire way slower than running a test
> directly in eclipse or with gradle, if it used standardout or error heavily.
> By using a list for saving the elements and converting them to an array
> afterwards, this problem is solved, and stdout-heavy surefire tests get
> faster.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
