[
https://issues.apache.org/jira/browse/MINDEXER-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16406227#comment-16406227
]
Martin Todorov commented on MINDEXER-49:
----------------------------------------
[~paleozogt],
Yeah, I understand your use case, but this opens up a different set of
problems. For example, given the following paths:
com/foo/bar/1.2/bar-1.2-gcc4.4.5.tar.gz
com/foo/bar/1.2-SNAPSHOT/bar-1.2-20180320.115830-5-gcc4.4.5.tar.gz
com/foo/bar/1.2-SNAPSHOT/bar-1.2-20180320.115830-5-gcc4.4.5.zip
When you have to parse the strings above, how will you know what is an
extension and what is a classifier...? (For the sake of both simplicity,
efficiency and speed, don't assume you can parse the .pom file).
If you could describe how this would work given the clarifications above, then
sure, somebody could probably implement it. At the moment, there is no clear
understanding of how to do this, (or so I'd say).
> M2GavCalculator does not parse GAV correctly for classifiers with dots
> ----------------------------------------------------------------------
>
> Key: MINDEXER-49
> URL: https://issues.apache.org/jira/browse/MINDEXER-49
> Project: Maven Indexer
> Issue Type: Bug
> Affects Versions: 4.1.1, 4.1.2
> Environment: all
> Reporter: René Zanner
> Priority: Critical
>
> When having a classifier with dots (classifier.with.dots) and an extension
> with or without dots (e.g. tar.gz), the calculation of Gav changes classifier
> and type/extension to something clearly not intended:
> || ||Attached artifact definition||M2GavCalculator result||
> ||classifier|classifier.with.dots|classifier|
> ||extension/type|tar.gz|with.dots.tar.gz|
> The problem seems to be located in lines 136ff, 175ff *and* 216ff (do you
> have a code duplication issue as well? ;-) ):
> {code}
> int nExtPos = tail.indexOf( '.' );
> ...
> ext = tail.substring( nExtPos + 1 );
> classifier = tail.charAt( 0 ) == '-' ? tail.substring( 1, nExtPos ) : null;
> {code}
> This code assumes that the classifier ends at the first dot in the "tail"
> (which is everything after the version number).
> Since Maven allows dots in classifiers _as well as in extensions_, the
> parsing has to be made more intelligent. So, it is not enough to just turn
> the parsing around and use the part after the last dot as extension and
> before it as classifier (that's why I used the 'tar.gz' extension in my
> example above).
> I do not have a solution for this except checking for well-known extensions
> (tar.gz, xml, jar, zip, a.s.o.) and build the classifier/extension parsing
> around it.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
