[
https://issues.apache.org/jira/browse/SCM-869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372508#comment-16372508
]
ASF GitHub Bot commented on SCM-869:
------------------------------------
GitHub user basinilya opened a pull request:
https://github.com/apache/maven-scm/pull/67
[SCM-869] fix gitexe list() implemented incorrectly
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/basinilya/maven-scm SCM-869
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-scm/pull/67.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #67
----
commit c50c7755d68b8d9c7a4aa46296724969cf58fcf5
Author: Ilya Basin <basinilya@...>
Date: 2018-02-22T07:10:20Z
[SCM-869] fix gitexe list() implemented incorrectly
----
> gitexe list() implemented incorrectly
> -------------------------------------
>
> Key: SCM-869
> URL: https://issues.apache.org/jira/browse/SCM-869
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
> Affects Versions: 1.9.5, 1.9.6
> Reporter: Ilya Basin
> Priority: Major
>
> Taking the Svn implementation as a model, ScmProvider.list() should be
> implemented as follows:
> * The command must directly query the remote repository for files
> * A local working copy is unnecessary and if it doesn't exist, the remote
> repository must not be checked out.
> * fileSet.getBasedir() indicates where to run the scm binary. The
> recommended value is ".".
> * fileSet.getFileList() indicates the files to list
> * repository indicates the repo URL
> Git (among other SCMs) does not support listing remote files, so the command
> should just fail.
> For listing files in a working copy, users should call the
> ScmProvider.status() method instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
