[
https://issues.apache.org/jira/browse/MJAVADOC-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258035#comment-16258035
]
ASF GitHub Bot commented on MJAVADOC-489:
-----------------------------------------
GitHub user io7m opened a pull request:
https://github.com/apache/maven-plugins/pull/137
[MJAVADOC-489] Find the main module descriptor
The existing code was checking for the existence of a file
"src/main/module-info.java" relative to the current directory. The
problem is that in a multi-module build, the current directory is
the project root, not the root of the current module. As a result,
the module descriptor was not being found and all dependencies were
ending up on the classpath instead.
Fixes: MJAVADOC-489
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/io7m/maven-plugins MJAVADOC-489
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-plugins/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 72046ff41b90a7667b07396623487f128542922f
Author: Mark Raynsford <c...@io7m.com>
Date: 2017-11-18T11:43:45Z
[MJAVADOC-489] Find the main module descriptor
The existing code was checking for the existence of a file
"src/main/module-info.java" relative to the current directory. The
problem is that in a multi-module build, the current directory is
the project root, not the root of the current module. As a result,
the module descriptor was not being found and all dependencies were
ending up on the classpath instead.
Fixes: MJAVADOC-489
----
> Javadoc plugin needs to set module path
> ---------------------------------------
>
> Key: MJAVADOC-489
> URL: https://issues.apache.org/jira/browse/MJAVADOC-489
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
> Affects Versions: 2.10.4
> Environment: macOS 10.12.5 build 175
> $java -version
> java version "9"
> Java(TM) SE Runtime Environment (build 9+175)
> Java HotSpot(TM) 64-Bit Server VM (build 9+175, mixed mode)
> Reporter: Philippe Marschall
> Assignee: Robert Scholte
> Fix For: 3.0.0
>
>
> Javadoc generation fails for Jigsaw modules that depends on other Jigsaw
> modules:
> {code}
> module c {
> requires a;
> requires b;
> }
> {code}
> while javadoc generation succeeds for modules a and b which have no module
> dependencies javadoc generation fails for module c which has module
> dependencies
> {code}
> MavenReportException: Error while generating Javadoc:
> [ERROR] Exit code: 1 -
> /Users/user/git/jigsaw/src/main/java/module-info.java:3: error: module not
> found: a
> [ERROR] requires a;
> [ERROR] ^
> [ERROR] /Users/user/git/jigsaw/src/main/java/module-info.java:4: error:
> module not found: b
> [ERROR] requires b;
> [ERROR] ^
> [ERROR]
> [ERROR] Command line was:
> /Library/Java/JavaVirtualMachines/jdk-9.jdk/Contents/Home/bin/javadoc
> @options @packages @argfile
> [ERROR]
> [ERROR] Refer to the generated Javadoc files in
> '/Users/user/git/jigsaw/target/apidocs' dir.
> {code}
> The issue seems to be that the javadoc plugin only ever sets {{-classpath}}.
> The javadoc plugin would have to set {{--module-path}} like the compiler
> plugin does.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
