joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with 
the top-navigation ena?
URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342918748
 
 
   >  To test, I understand that any rendering of the skin with a nav bar in a 
little screen should be used: we already have a few when running "mvn -Prun-its 
verify"
   
   Great. Will take a look.
   
   > But with the patch applied, there is a space added before the topbar: to 
me, the patch breaks topbar positionning.
   
   Yeah, I did have to tweak some CSS down in HBase. I assumed that was 
something we were doing down there -- will have to circle around and see if I 
can make the equivalent change here instead :)
   
   > Please share a screenshot of the issue you get in hbase, then the result 
once the patch fixes the issue
   
   Acknowledged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to