[ 
https://issues.apache.org/jira/browse/MSHADE-265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239265#comment-16239265
 ] 

Robert Scholte commented on MSHADE-265:
---------------------------------------

We had this discussion with a couple of Maven teammember and Mark Reinhold at 
FOSDEM and we came to the conclusion we should never merge module descriptors. 
The main reason: you will break strong encapsulation.
There is still an open issue for it on the JPMS issue list, waiting to be 
picked up in a next Java release.
I think in case of libraries this cannot be solved. But in case of applications 
I hope implementing MSHADE-262 will do the job.

> correct merging of module-info in shades
> ----------------------------------------
>
>                 Key: MSHADE-265
>                 URL: https://issues.apache.org/jira/browse/MSHADE-265
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>            Reporter: Romain Manni-Bucau
>            Priority: Trivial
>
> Should work by merging of the encountered module info jut also automatic 
> module name in manifest. The hard part being removing the not needed entries 
> which are sometimes not simply the ones of the included classes - SPI need it 
> still



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to