[ https://issues.apache.org/jira/browse/SUREFIRE-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172109#comment-16172109 ]
Tibor Digana commented on SUREFIRE-1264: ---------------------------------------- [~cbeikov] [~christian.beikov] I do not have this problem on Windows but my tests failed: {quote}> java.lang.AssertionError: Correlation variable $cor0 should be defined > at > org.apache.calcite.adapter.enumerable.EnumerableRelImplementor.getCorrelVariableGetter(EnumerableRelImplementor.java:480){quote} and this is build summary: {quote}[INFO] Calcite ........................................... SUCCESS [ 6.433 s] [INFO] Calcite Linq4j .................................... SUCCESS [ 13.526 s] [INFO] Calcite Core ...................................... FAILURE [01:31 min] [INFO] Calcite Cassandra ................................. SKIPPED [INFO] Calcite Druid ..................................... SKIPPED [INFO] Calcite Elasticsearch ............................. SKIPPED [INFO] Calcite Examples .................................. SKIPPED [INFO] Calcite Example CSV ............................... SKIPPED [INFO] Calcite Example Function .......................... SKIPPED [INFO] Calcite File ...................................... SKIPPED [INFO] Calcite MongoDB ................................... SKIPPED [INFO] Calcite Pig ....................................... SKIPPED [INFO] Calcite Piglet .................................... SKIPPED [INFO] Calcite Plus ...................................... SKIPPED [INFO] Calcite Spark ..................................... SKIPPED [INFO] Calcite Splunk .................................... SKIPPED [INFO] Calcite Ubenchmark ................................ SKIPPED{quote} I have a suspicion in commit {{67c06d5876dcabc037de9b5f4cc226beeedcb379}} because this touched {{ParallelComputerBuilder}} and you run parallel tests. Can you please make an experiment? I think now only you can do it. Please clone project {{https://github.com/apache/maven-surefire/}} from master and revert only changes in class {{ParallelComputerBuilder.java}}. This means the line 432 is {{runs.add( runner );}} and you should call it in IF like this: {code:java} if ( children != 0 ) { runs.add( runner ); } {code} Save this change and install Surefire project without running tests: {{mvn -DskipTests install}}. Now edit POMs in your project and use another version of Surefire {{2.21.0-SNAPSHOT}}. Run you project with {{no-snapshot-updates}} like this {{mvn -nsu -Dsurefire.useFile=false -Dcheckstyle.skip=true test}}. If the same problem was reproducible before without having Docker, you can easily run it on your local machine without Docker. Maybe this would be easier. What happens with the test after this? > Some tests can be lost when running in parallel with parameterized tests > ------------------------------------------------------------------------ > > Key: SUREFIRE-1264 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1264 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support > Affects Versions: 2.19.1 > Environment: Maven 3.3.9 > Java 1.8.0_45 (Oracle) > System: OS X > Reproduced on Linux too, with both OpenJDK 7 and Java 7 from Oracle. > Reporter: Jean-Luc Derrien > Assignee: Tibor Digana > Fix For: 2.20.1 > > Attachments: failure-2.21-snapshot-SUREFIRE-1264.zip, pom.xml > > Time Spent: 144h > Remaining Estimate: 24h > > Hello, > It appears some tests can be lost when using the parallel mode with > parameterized tests. Here is a [small > project|https://github.com/jderrien/surefire-junit-tests/tree/simple-1] I've > used to try to reproduce the issue we have seen. > This is not something that happens on every run, but it's quite frequent. > With this loop, the problem should appear in less than 2 minutes, maybe on > the first run when (un)lucky: > {code} > time while true; do mvn clean test > last.log ; tail -25 last.log ; if [ > "$(grep -c 'Tests run: 12' last.log)" == "0" ]; then break; fi ; done > {code} > Normal run: > {noformat} > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running [p2] > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 - > sleeptime = 1 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 - > sleeptime = 1 => stop > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 - > sleeptime = 2 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 - > sleeptime = 2 => stop > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 - > sleeptime = 5 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 - > sleeptime = 5 => stop > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.006 sec - > in [p2] > Running [p2] > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - > in [p2] > Results : > Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 > {noformat} > When tests have been lost (here one test lost according to the output): > {noformat} > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running [p2] > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p0] - p0 - > sleeptime = 5 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p2] - p2 - > sleeptime = 1 => start > com.appnexus.viewability.core.surefireJunitTests.ATest.methodA1[p1] - p1 - > sleeptime = 2 => start > Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - > in [p2] > Running [p2] > Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec - > in [p2] > Results : > Tests run: 11, Failures: 0, Errors: 0, Skipped: 0 > {noformat} > Note: there are 3 test classes and 18 tests on the [master > branch|https://github.com/jderrien/surefire-junit-tests/tree/master] and it's > even more frequent/easy to reproduce. -- This message was sent by Atlassian JIRA (v6.4.14#64029)