[ http://jira.codehaus.org/browse/MECLIPSE-164?page=comments#action_77297 ] Kenney Westerhof commented on MECLIPSE-164: -------------------------------------------
Hm, I've checked to see if there's another way to fix this, but eclipse is very limited. It could probably be done by defining a user library, but that's at the workspace level. The patch looks ok, but a few suggestions: 1) the code is not formatted properly - please take care of that. Also don't add 'Modif FL' statements. 2) I'd rather see the getClassFoldername moved to IdeUtils as 'fixSepatator', moving the code from 'toRelativeAndFixSeparator' 3) could you move the check if it is a class folder to a new method in IdeDependency? So remove the loop in the setDeps, move the check to a separate method. 4) Finally, could you re-use the loop that's now done for isPde()? That already loops all dependencies.. You could add a switch there to see if it's PDE&provided || linkedFolder. Don't get me wrong, your solution is perfect, but this might reduce the (already high) number of utility methods and if/else stuff a bit.. If you don't want to refactor, just fix the formatting and it'll be done later on. Thanks! > class folders not handled > ------------------------- > > Key: MECLIPSE-164 > URL: http://jira.codehaus.org/browse/MECLIPSE-164 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: dependency resolution > Affects Versions: 2.2 > Reporter: Francois Loison > Attachments: patch.classfolder.txt > > > I defined in POM a class folder: > <dependency> > <groupId>com.ptc</groupId> > <artifactId>wt.codebase</artifactId> > <version>1.0</version> > <scope>system</scope> > <systemPath>c:/dev/java/maven/wdc.ptc/codebase</systemPath> > </dependency> > This allows to add c:/dev/java/maven/wdc.ptc/codebase to compile classpath. > Generated Eclipse .classpath file contains following entry: > <classpathentry kind="lib" path="C:/Dev/java/maven/wdc.ptc/codebase"/> > This entry is failing: Eclipse 3.2 doesn't accept external project folders > for class folders. > To resolve this, I create manually a linked folder in .project and defines > class folder to point on linked folder. > This may be an hint for resolution. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
