[
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149634#comment-16149634
]
ASF GitHub Bot commented on SUREFIRE-1383:
------------------------------------------
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/157
@owenfarrell
My tests passed on this code. I have to continue to develop and refactor
more.
List<Artifact> testDepends = project.getTestArtifacts();
removeReactorDependencies( session.getSortedProjects(),
testDepends.iterator() );
List<File> dependenciesToScan = filter( testDepends,
asList( getDependenciesToScan() ) );
TestListResolver testFilter = getIncludedAndExcludedTests();
DefaultScanResult scanResult = new DependencyScanner(
dependenciesToScan, testFilter ).scan();
for ( MavenProject project : session.getSortedProjects() )
{
if ( !"pom".equals( project.getPackaging() ) &&
!containsProjectArtifact( testDepends, project ) )
{
// zapracuj getDependenciesToScan()
File reactorChildProjectOutputDir = new File(
project.getBuild().getOutputDirectory() );
if ( reactorChildProjectOutputDir.isDirectory() )
{
DirectoryScanner scanner = new
DirectoryScanner( reactorChildProjectOutputDir, testFilter );
scanResult = scanResult.append( scanner.scan()
);
}
}
}
> dependenciesToScan Does Not Leverage Classpath Elements
> --------------------------------------------------------
>
> Key: SUREFIRE-1383
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
> Affects Versions: 2.20
> Reporter: Owen Farrell
> Assignee: Tibor Digana
> Fix For: 2.20.1
>
> Attachments: scanned-dependencies-sample.zip
>
> Time Spent: 48h
> Remaining Estimate: 24h
>
> The <dependenciesToScan> configuration attribute relies solely on installed
> artifacts. This is an issue when the targeted dependencies were built as part
> of the current session. The net result is that stale artifacts are used (i.e.
> if the dependency has changed since it was last installed) or the tests are
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
> And the first module built includes test classes as part of the project
> artifact
> And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
> And tests should be executed with each module
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
