[ 
https://issues.apache.org/jira/browse/SUREFIRE-1396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106186#comment-16106186
 ] 

ASF GitHub Bot commented on SUREFIRE-1396:
------------------------------------------

GitHub user jon-bell opened a pull request:

    https://github.com/apache/maven-surefire/pull/161

    SUREFIRE-1396: Provider class path is incorrect for custom provider in 
Failsafe

    Hi,
    When using a custom Surefire provider with Surefire (not Failsafe), the 
"provider classpath" contains only the provider and surefire-api. However, when 
using a custom provider with Failsafe, the provider class path ends up 
including a lot more... it seems like perhaps all plugins that are loaded? This 
has caused some mayhem for me when using a custom provider in projects that use 
a specific version of SLF4J... because then failsafe forces 1.5.6 to be loaded 
(from this process of incorrectly finding the custom provider), causing a crash.
    
    This PR contains an integration test case showing the bug and a patch to 
solve it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jon-bell/maven-surefire SUREFIRE-1396

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-surefire/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit 04f66cdd828d131a028eb400d1ed26fe104fe3f2
Author: Jonathan Bell <[email protected]>
Date:   2017-07-25T03:43:36Z

    SUREFIRE-1396: Test case demonstrating broken handling of classpath for 
custom runners in failsafe, plus a fix

----


> Provider class path is incorrect for custom provider in Failsafe
> ----------------------------------------------------------------
>
>                 Key: SUREFIRE-1396
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1396
>             Project: Maven Surefire
>          Issue Type: Bug
>            Reporter: Jonathan Bell
>
> Hi,
> When using a custom Surefire provider with Surefire (not Failsafe), the 
> "provider classpath" contains only the provider and surefire-api. However, 
> when using a custom provider with Failsafe, the provider class path ends up 
> including a lot more... it seems like perhaps all plugins that are loaded? 
> This has caused some mayhem for me when using a custom provider in projects 
> that use a specific version of SLF4J... because then failsafe forces 1.5.6 to 
> be loaded (from this process of incorrectly finding the custom provider), 
> causing a crash.
> It is a simple fix (3 lines in AbstractSurefireMojo - it had the name of the 
> Surefire plugin hardcoded, which isn't correct when it's actually Failsafe). 
> I've got a patched fork of master on GitHub 
> (https://github.com/jon-bell/maven-surefire/commit/04f66cdd828d131a028eb400d1ed26fe104fe3f2)
>  that fixes it and an integration test that demonstrates the flaw. I am not 
> 100% sure on the formatting of the integration test (i.e., I am opening a 
> JIRA ticket so that I suppose I can name it under the JIRA issue? How should 
> I specify the current version of surefire in the integration test package?) - 
> if the fix is welcome against master I'd be happy to open a PR on GitHub. I 
> am also happy to merge against a different branch if it's more helpful.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to