[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032156#comment-16032156
 ] 

Guillaume Boué edited comment on MCHECKSTYLE-337 at 5/31/17 11:00 PM:
----------------------------------------------------------------------

Outputting a plain file and a XML file in case of {{plain}} sounds good. The 
temporary XML file (generated in {{java.io.tmpdir}} for example) can be deleted 
by the goal when it has finished. No need to change anything for {{xml}}. This 
way, the current restriction of "reject {{plain}}" can be tightened to "reject 
{{plain}} only if {{skipExec}} is {{true}}".


was (Author: gboue):
Outputting a plain file and a XML file in case of {{plain}} sounds good. The 
temporary XML file (generated in {{java.io.tmpdir}} for example) can be deleted 
by the goal when it has finished. No need to change anything for {{xml}}. This 
way, the current restriction of "reject {{plain}}" can be loosened to "reject 
{{plain}} only if {{skipExec}} is {{true}}".

> checkstyle:check only supports xml output format, but the docs say it 
> supports plain as well
> --------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-337
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-337
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>          Components: checkstyle:check
>    Affects Versions: 2.17
>            Reporter: Stig Rohde Døssing
>            Priority: Minor
>
> The documentation for the check goal at 
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html#outputFileFormat
>  mentions "plain" as a valid option for file output. This is not true, the 
> mojo only supports XML.
> I'd prefer added support for plain output, but the docs should be fixed if 
> that is not possible.
> Taking a look at the code, it looks like the only reason plain isn't 
> supported is because the check mojo needs to parse the output file to figure 
> out if there were style violations. An option would be counting errors with 
> the AuditListener instead, but this would break support for skipExec. An 
> alternative would be to output an extra XML result file if the output format 
> isn't XML.
> I'd be happy to implement either solution.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to