[ 
https://issues.apache.org/jira/browse/DOXIA-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906308#comment-15906308
 ] 

Marc Campbell commented on DOXIA-554:
-------------------------------------

[~vsch] The following can be added to 
"doxia-modules/doxia-module-markdown/pom.xml" to set the enforcer 
enforceBytecodeVersion to 1.7 for the doxia-module-markdown.

{code:xml}
<plugins>
  <plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-enforcer-plugin</artifactId>
    <executions>
      <execution>
        <id>enforce-bytecode-version</id>
        <goals>
          <goal>enforce</goal>
        </goals>
        <configuration>
          <rules>
            <enforceBytecodeVersion>
              <maxJdkVersion>1.7</maxJdkVersion>
            </enforceBytecodeVersion>
          </rules>
          <fail>true</fail> 
        </configuration>
      </execution>
    </executions>
  </plugin>        
  <plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-compiler-plugin</artifactId>
    <!-- ... ->
{code}

I checked a build with the addition of the above code to 
[https://github.com/vsch/maven-doxia]. After the enforcer 
enforceBytecodeVersion is updated to maxJdkVersion 1.7, the next apparent 
hurdle is licensing.

The automatic license checker {{org.apache.rat:apache-rat-plugin:0.11:check 
(rat-check)}} found the licenses to be "Unapproved: 2 unknown: 2 generated: 0 
approved: 8".

Two files in question appear to be ones that Vladimir, as the original code 
author and copyright holder, could adjust. {{MarkdownDoxiaNodeRenderer.java}} 
and {{MarkdownDoxiaExtension.java}} have:
    
{code:java}
/* Copyright (c) 2015-2016 Vladimir Schneider <...>, all rights reserved.
 *
 * This code is private property of the copyright holder and cannot be used 
without
 * having obtained a license or prior written permission of the of the 
copyright holder.
{code}

>From the report it appears the 2 unknown licenses are also the unapproved 
>licences. Building the module with the above enforcer change will provide the 
>{{rat.txt}} licensing report.



> Parsing time for Markdown documents can take very long and hang site 
> generation
> -------------------------------------------------------------------------------
>
>                 Key: DOXIA-554
>                 URL: https://issues.apache.org/jira/browse/DOXIA-554
>             Project: Maven Doxia
>          Issue Type: Bug
>          Components: Module - Markdown
>    Affects Versions: 1.7
>            Reporter: Michael Benz
>         Attachments: maven-pom-sample-pegdown-performance.zip
>
>
> The parsing time for Markdown documents can take very long and hang site 
> generation when e.g. long tables are being generated.
> The author of pegdown has marked the pegdown project deprecated since 
> 2016-12-14 [pegdown.org|https://github.com/sirthias/pegdown/] and advises to 
> switch to [flexmark-java|https://github.com/vsch/flexmark-java].
> {quote}
> The project is essentially unmaintained with tickets piling up and crucial 
> bugs not being fixed.
> pegdown's parsing performance isn't great. In some cases of pathological 
> input runtime can even become exponential, which means that the parser either 
> appears to "hang" completely or abort processing after a time-out.
> {quote}
> Since the parsing timeout was increased in DOXIA-498 it is now possible to 
> "hang" the site creation with a longer table like the one in this example.
> In case this sample is rendered using version 3.3 of the maven site



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to