[ 
https://issues.apache.org/jira/browse/MRELEASE-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893527#comment-15893527
 ] 

Henning Schmiedehausen commented on MRELEASE-979:
-------------------------------------------------

(good bot, ASF Github Bot)

A few words to the changes: 

This reintroduces the branchoperation boolean to the Naming request again and I 
know that [~rfscholte] cringed at that. Let me explain: As you want the default 
naming policy to live within the DefaultNamingPolicy class, here is a dirty 
secret: We actually have two naming policies: 

- one for tags, where the name is created from "artifactid - version" (unless 
an ScmTagName is given) 
- one for branches, where the name is unconditionally empty unless explicitly 
given

I updated the NamingPolicy class (and default implementation) to support two 
methods instead of one, one for tag names, one for branches.


The logic in the InputVariablesPhase is a bit delicate and reordering it tends 
to break in subtle ways. I tested this back and forth with a ll the projects 
that we have and I think that this patch works in every scenario. 


> Support NamingPolicies to manage Branch and Tag names
> -----------------------------------------------------
>
>                 Key: MRELEASE-979
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-979
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>          Components: branch, prepare, update-versions
>    Affects Versions: 2.5.3
>            Reporter: Henning Schmiedehausen
>             Fix For: 3.0.0
>
>
> The newly introduced VersionPolicy facility allows managing the development 
> and release versions of projects when releasing, branching and updating 
> versions.
> Most organizations will also have a policy around how branches and tags are 
> named (which often have to match specific versioning patterns). The current 
> VersionPolicy implementations do not allow this but it should be possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to