[ https://issues.apache.org/jira/browse/MSHARED-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15808698#comment-15808698 ]
Hudson commented on MSHARED-610: -------------------------------- SUCCESS: Integrated in Jenkins build maven-shared Jigsaw #716 (See [https://builds.apache.org/job/maven-shared%20Jigsaw/716/]) [MSHARED-610] PrettyPrintXMLWriter internally uses java.io.PrintWriter without checking for any errors. o Removed an incorrect '@throws' tag from the Javadoc. o Updated to provide causing exception with any AssertionErrors added in last commit. (schulte: [http://svn.apache.org/viewvc/?view=rev&rev=1777862]) * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/Xpp3Dom.java [MSHARED-610] PrettyPrintXMLWriter internally uses java.io.PrintWriter without checking for any errors. o Updated the 'XMLWriter' interface method to allow implementations to throw 'IOException's and made the implementations stop silently ignore any IO errors. This commit makes the API for writig match the API for reading which also throws 'IOException's. (schulte: [http://svn.apache.org/viewvc/?view=rev&rev=1777861]) * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/PrettyPrintXMLWriter.java * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/XMLWriter.java * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/XmlWriterUtil.java * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/Xpp3Dom.java * (edit) maven-shared-utils/src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomWriter.java * (edit) maven-shared-utils/src/test/java/org/apache/maven/shared/utils/xml/PrettyPrintXmlWriterTest.java > PrettyPrintXMLWriter internally uses java.io.PrintWriter without checking for > any errors. > ----------------------------------------------------------------------------------------- > > Key: MSHARED-610 > URL: https://issues.apache.org/jira/browse/MSHARED-610 > Project: Maven Shared Components > Issue Type: Bug > Reporter: Christian Schulte > Assignee: Christian Schulte > Priority: Critical > Fix For: maven-shared-utils-3.2.0 > > > {{org.apache.maven.shared.utils.xml.PrettyPrintXMLWriter}} internally uses a > {{java.io.PrintWriter}}. That class is catching all {{IOException}} s > internally and does not propagate any exception itseld. Instead the > {{checkError}} method is provided to check for any error during performing > IO. The {{PrettyPrintXMLWriter}} must not silently ingore any exception > during writing and either needs to provide a {{checkError}} method itself (to > follow a bad idea) or should be updated to check for any IO errors and throw > an exception. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
