[
https://issues.apache.org/jira/browse/WAGON-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15736634#comment-15736634
]
ASF GitHub Bot commented on WAGON-469:
--------------------------------------
GitHub user mcculls opened a pull request:
https://github.com/apache/maven-wagon/pull/31
[WAGON-469] wagon-http does not enable Expect-Continue by default
There appear to be two issues:
* Expect-Continue is not enabled for PUT when no configuration is provided
* The default Expect-Continue configuration parameter uses the wrong key
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcculls/maven-wagon
WAGON-469-enable-expect-continue-by-default
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-wagon/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 5913a71aaf556a8583decf5b1e5c39e946a153a8
Author: Stuart McCulloch <mccu...@gmail.com>
Date: 2016-12-09T23:04:25Z
[WAGON-469] enable Expect-Continue for PUTs when no configuration is
provided
commit 6aab1bd0685c00cd72253b9ba7e6e0d6da7e3172
Author: Stuart McCulloch <mccu...@gmail.com>
Date: 2016-12-09T23:05:36Z
[WAGON-469] use correct key for default Expect-Continue configuration
parameter
(HTTP.EXPECT_CONTINUE constant is the expectation name, not the parameter
key)
----
> wagon-http does not enable Expect-Continue by default
> -----------------------------------------------------
>
> Key: WAGON-469
> URL: https://issues.apache.org/jira/browse/WAGON-469
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-http
> Affects Versions: 2.10
> Reporter: Stuart McCulloch
>
> According to
> http://maven.apache.org/guides/mini/guide-http-settings.html#The_Basics PUT
> requests made with the HTTP wagon will enable Expect-Continue support by
> default.
> However testing shows that when no {{<httpConfiguration>}} is provided in
> settings.xml Expect-Continue support is not enabled by wagon-http for PUT
> requests.
> Similarly, when an empty {{<httpConfiguration>}} section is provided in
> settings.xml, Expect-Continue support is not enabled by wagon-http for PUT
> requests.
> Only when a {{<httpConfiguration>}} section like:
> {code:xml}
> <put>
> <params>
> <property>
> <name>http.protocol.expect-continue</name>
> <value>%b,true</value>
> </property>
> </params>
> </put>
> {code}
> is provided in settings.xml is Expect-Continue support enabled.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
