[ https://issues.apache.org/jira/browse/MSHADE-241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15697580#comment-15697580 ]
ASF GitHub Bot commented on MSHADE-241: --------------------------------------- GitHub user vietj opened a pull request: https://github.com/apache/maven-plugins/pull/96 Groovy extension module transformer https://issues.apache.org/jira/browse/MSHADE-241 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vietj/maven-plugins trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/maven-plugins/pull/96.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #96 ---- commit 27d5fe6adc4fb56ea65d619b35b59d3367072d0a Author: Julien Viet <jul...@julienviet.com> Date: 2016-11-25T16:18:49Z Groovy transformer for Maven Shade Plugin commit f0b667d5296792a2a1a6c163eac97dfbea950fa0 Author: Julien Viet <jul...@julienviet.com> Date: 2016-11-26T08:51:51Z Update test author to myself ---- > Groovy extension module transformer > ----------------------------------- > > Key: MSHADE-241 > URL: https://issues.apache.org/jira/browse/MSHADE-241 > Project: Maven Shade Plugin > Issue Type: Improvement > Affects Versions: 2.4.3 > Reporter: Julien Viet > Assignee: Olivier Lamy (*$^¨%`£) > Fix For: 2.4.4 > > > Currently Groovy uses a specific format for its extension modules located > under the name META-INF/services/org.codehaus.groovy.runtime.ExtensionModule . > The content is actually a property file with 4 entries: > - moduleName > - moduleVersion > - extensionClasses : a comma separated list of class names > - staticExtensionClasses : :a comma separated list of class names > A correct merge operation should merge the list extensionClasses and > staticExtensionClasses > Such merge operation can be implemented as a resource transformer. It not > require any of a specific Groovy class and can operate on plain property > files. > I am willing to contribute this with tests as a resource transformer. In fact > I already have an working implementation (quite trivial). -- This message was sent by Atlassian JIRA (v6.3.4#6332)