[
https://issues.apache.org/jira/browse/MNG-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513674#comment-15513674
]
Hervé Boutemy commented on MNG-6093:
------------------------------------
proof of concept implemented in
http://git-wip-us.apache.org/repos/asf/maven/commit/6d8d0e1d
in fact, I added 2 rendering methods in SimpleLogger to implement them in an
extension: IMHO, this could be an interface slf4j-simple with a default
implementation and a configurable override...
I don't know precisely what NOTICE has to be added, since it contains a copy of
some slf4j code
and I don't know if it is really the way to go, but at least, "it works" for
now as a POC
> create a slf4j-simple provider extension that supports level color rendering
> ----------------------------------------------------------------------------
>
> Key: MNG-6093
> URL: https://issues.apache.org/jira/browse/MNG-6093
> Project: Maven
> Issue Type: New Feature
> Components: Logging
> Reporter: Hervé Boutemy
>
> With color support, core Maven and plugins do general message colorization
> (or more high-level "message styling" through maven-shared-utils)
> slf4j provider however has to add color:
> - for log level output (DEBUG/INFO/WARNING/ERROR)
> - for stacktrace rendering
> That's why we use Gossip slf4j provider: it has sufficient little extension
> points to add this, with just a little bit of code (see
> http://maven.apache.org/ref/3-LATEST/maven-embedder/apidocs/org/apache/maven/cli/logging/impl/gossip/package-summary.html
> )
> The issue with switching to Gossip slf4j provider is that people don't know
> it and it does not have the same features as slf4j-simple, the configuration
> file is not the same (name nor content).
> But the extension points are not that big: if slf4j-simple provider just made
> a few methods protected instread of private, it would be extensible
> What if we just copy slf4j-simple to change the signatures and create small
> extension classes? The license permits it, we can try it and eventually see
> with slf4j if the modification can go into official release
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
