[ 
https://issues.apache.org/jira/browse/SUREFIRE-1276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15431635#comment-15431635
 ] 

Gili commented on SUREFIRE-1276:
--------------------------------

[~tibor17] Will do. On a side-note, don't you find the conditional of 
https://github.com/apache/maven-surefire/commit/6e5fb5695a48ad072cc354e31b8fd82656b9d320#diff-fa9299aa9dbda1fe1c3f400814d2b25fR142
 a bit confusing? I would recommend adding brackets to clarify the operator 
ordering. Also, its not clear when {{!msg.trim().endsWith( "\n" )}} would ever 
return true. I'm guessing that replacing that with {{!msg.trim().isEmpty()}} 
would result in the same behavior but be more readable.

> trimStackTrace trims newlines in exception message
> --------------------------------------------------
>
>                 Key: SUREFIRE-1276
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1276
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Plugin
>            Reporter: Gili
>            Assignee: Tibor Digana
>              Labels: documentation
>
> I am throwing an exception whose message contains newlines for readability. 
> When {{<trimStackTrace>}} is true (the default value) Surefire is removing 
> all newlines.
> Expected behavior: Consider moving this functionality out of 
> {{<trimStackTrace>}} into its own parameter. Regardless of which parameter 
> enables this behavior, please document it at 
> http://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html ... 
> right now there is no mention of this behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to