[
https://issues.apache.org/jira/browse/MNG-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14954676#comment-14954676
]
Mark Struberg commented on MNG-5649:
------------------------------------
-1 for using Guava all over. I've used in in the past and it turned out to
introduce way more backward incompatibility headache than commons. And
IllegalArgumentException is btw much more explicit than a NullPointerException.
> Stop abusing IllegalArgumentException in case of null and use Guava's
> Preconditions
> -----------------------------------------------------------------------------------
>
> Key: MNG-5649
> URL: https://issues.apache.org/jira/browse/MNG-5649
> Project: Maven
> Issue Type: Bug
> Affects Versions: 3.2.1
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Fix For: 3.3.7
>
>
> In several spots of Maven Core, IAE is thrown where an argument is null. This
> should be turned into {{NullPointerException}} since JDK adheres to is and
> the
> [description|http://docs.oracle.com/javase/6/docs/api/java/lang/NullPointerException.html]
> of this exception indicates that and Effective Java does that too.
> I possible fix version could next minor: 3.3. Is no one is opposed it could
> even be 3.2.2.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)