[ https://issues.apache.org/jira/browse/MNG-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933710#comment-14933710 ]
ASF GitHub Bot commented on MNG-5877: ------------------------------------- Github user michael-o commented on the pull request: https://github.com/apache/maven/pull/65#issuecomment-143833287 Can you ping me by Thursday, I will review and merge?! Did you really observe it to fail with Thai locale? > maven-aether-provider does not always generate snapshot versions using > Gregorian calendar year > ----------------------------------------------------------------------------------------------- > > Key: MNG-5877 > URL: https://issues.apache.org/jira/browse/MNG-5877 > Project: Maven > Issue Type: Bug > Reporter: Anders Forsell > > I am using the maven-aether-provider in my software and have an issue when > Thailand users are publishing their snapshot versions get the Buddhist > calendar year (offset of 543 years). > I have located the problem to be in the RemoteSnapShotMetaData class: > {code:title=RemoteSnapShotMetaData.java|borderStyle=solid} > DateFormat utcDateFormatter = new SimpleDateFormat( > "yyyyMMdd.HHmmss" ); > utcDateFormatter.setTimeZone( TimeZone.getTimeZone( "UTC" ) ); > snapshot = new Snapshot(); > snapshot.setBuildNumber( getBuildNumber( recessive ) + 1 ); > snapshot.setTimestamp( utcDateFormatter.format( new Date() ) ); > {code} > The fix should be to explicitly set the calendar to be Gregorian: > {code:title=RemoteSnapShotMetaData.java|borderStyle=solid} > DateFormat utcDateFormatter = new SimpleDateFormat( > "yyyyMMdd.HHmmss" ); > utcDateFormatter.setTimeZone( TimeZone.getTimeZone( "UTC" ) ); > utcDateFormatter.setCalendar(new GregorianCalendar()); > snapshot = new Snapshot(); > snapshot.setBuildNumber( getBuildNumber( recessive ) + 1 ); > snapshot.setTimestamp( utcDateFormatter.format( new Date() ) ); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)