[ 
https://issues.apache.org/jira/browse/MDEP-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14738613#comment-14738613
 ] 

Adrian Price commented on MDEP-481:
-----------------------------------

I see a related problem in the case where the <includes> pattern matches just 
one file and <destFileName> has been specified - the unpacked file uses the 
entire original path within the dependency archive and ignores the 
destFileName. For example:
{code:xml}
<configuration>
  <artifactItems>
    <artifactItem>
      <groupId>g</groupId>
      <artifactId>a</artifactId>
      <version>v</version>
      <type>jar</type>
      <includes>**/www.xxx</includes>
      <outputDirectory>od</outputDirectory>
      <destFileName>yyy.zzz</destFileName>
    </artifactItem>
  </artifactItems>
</configuration>
{code}
You would expect the matching file (say) a/b/c/www.xxx to be copied to 
od/yyy.zzz but instead it ends up as od/a/b/c/www.xxx.

> <destFileName> is getting ignored
> ---------------------------------
>
>                 Key: MDEP-481
>                 URL: https://issues.apache.org/jira/browse/MDEP-481
>             Project: Maven Dependency Plugin
>          Issue Type: Bug
>    Affects Versions: 2.10
>         Environment: Win 7 Pro SP1, 64 Bit, JDK 8u40
>            Reporter: Markus Karg
>
> With the following configuration, the entry <destFileName> is getting 
> ignored, but the original name as matched by the <includes> pattern is used 
> for the destination file name:
> <artifactItem>
>       <groupId>g</groupId>
>       <artifactId>a</artifactId>
>       <type>t</type>
>       <includes>prefix*suffix.ext</includes>
>       <destFileName>name.ext</destFileName>
> </artifactItem>
> This is problematic in case the exact file name is unknown or irrelevant, e. 
> g. if a file shall be picked by prefix solely, while the suffix (version, 
> classifier, etc.) are irrelevant, as the destFileName would leave out suffix 
> anyways.
> As it is the POM author's responsibility to not overwrite files, the default 
> behaviour should not be to ignore <destFileName> in case of multiple pattern 
> matches, but the files should simply auto-overwrite each other. Typically the 
> default use case where a POM author would use patterns and destFileName at 
> the same time, anyways is when he knows for sure there is can be only one 
> match.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to