[ 
https://issues.apache.org/jira/browse/MCLEAN-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14728634#comment-14728634
 ] 

Michał edited comment on MCLEAN-64 at 9/3/15 7:52 AM:
------------------------------------------------------

OK I have found the issue!

Situation
You have a parent project and a child project, both have to use the plugin.

Now; 
- in parent project you specify some filesets.
- in child project you specify some filesets.

---
What I think is expected:
Plugin read both parent's and child's filesets and cleans them all.

What happens:
Plugin OVERRIDES the parent's filesets with child's filesets. Filesets are 
overriden in order. HOWEVER the parents configuration for the fileset is not 
cleared!

---
My situation:
Parent .pom:
{code:xml}
<filesets>
   <fileset>
      <directory>test-output</directory>
   </fileset>
   <fileset>
     <directory>${basedir}/</directory>
     <includes>
        <include>.bindings</include>
     </includes> 
   </fileset>
</filesets>
{code}

Childs pom:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

And with the above information; the config read by plugin is:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
        <includes>
            <include>.bindings</include>
        </includes>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

instead of a config with 5 filesets.




was (Author: atais):
OK I have found the issue!

Situation
You have a parent project and a child project, both have to use the plugin.

Now; 
- in parent project you specify some filesets.
- in child project you specify some filesets.

---
What I think is expected:
Plugin read both parent's and child's filesets and cleans them all.

What happens:
Plugin OVERRIDES the parent's filesets with child's filesets. Filesets are 
overriden in order. HOWEVER the parents configuration for the fileset is not 
cleared!

---
My situation:
Parent .pom:
{code:xml}
<filesets>
   <fileset>
      <directory>test-output</directory>
   </fileset>
   <fileset>
     <directory>${basedir}/</directory>
     <includes>
        <include>.bindings</include>
     </includes> 
   </fileset>
</filesets>
{code}

Childs pom:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

And with the above information; the filesets read by plugin is:
{code:xml}
<filesets>
    <fileset>
        <directory>node</directory>
    </fileset>
    <fileset>
        <directory>node_modules</directory>
        <includes>
            <include>.bindings</include>
        </includes>
    </fileset>
    <fileset>
        <directory>src/main/webapp/bower_components</directory>
    </fileset>
</filesets>
{code}

instead of a config with 5 filesets.



> Multiple filesets for removing directories 
> -------------------------------------------
>
>                 Key: MCLEAN-64
>                 URL: https://issues.apache.org/jira/browse/MCLEAN-64
>             Project: Maven Clean Plugin
>          Issue Type: Bug
>    Affects Versions: 2.6.1
>         Environment: Apache Maven 3.3.3 
> (7994120775791599e205a5524ec3e0dfe41d4a06; 2015-04-22T13:57:37+02:00)
> Maven home: /home/msiatkowski/.linuxbrew/Cellar/maven/3.3.3/libexec
> Java version: 1.8.0_51, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "3.13.0-61-generic", arch: "amd64", family: "unix"
>            Reporter: Michał
>
> If you configure the plugin in the way shown below:
> {code:xml}
> <configuration>
>     <filesets>
>         <fileset>
>             <directory>node</directory>
>         </fileset>
>         <fileset>
>             <directory>node_modules</directory>
>         </fileset>
>         <fileset>
>             <directory>src/main/webapp/bower_components</directory>
>         </fileset>
>     </filesets>
> </configuration>
> {code}
> The 2nd fileset always contains
> {code:xml}
> <includes>
>     <include>.bindings</include>
> </includes>
> {code}
> even when not specified.
> The issue is described here:
> http://stackoverflow.com/questions/32329141/maven-clean-plugin-is-not-removing-all-given-directories/32330215#32330215



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to