[ http://jira.codehaus.org/browse/MRM-153?page=comments#action_73629 ] Brett Porter commented on MRM-153: ----------------------------------
Hi Nicolas. The test looks pretty, good, but some comments: - this will require downloading from ibiblio, which is not very good. I think it would be better to have the 'managed' repository created in, say, target/test/managed-repository instead of src/test/maven-2.x-repository, and use maven-2.x repository as the proxy repo (using file:// ... as the URL) - in the patch, you should omit binary files. Besides, its not necessary to have a full size servlet jar for this test - the code and test should be in the proxy module instead of core. The code should be part of the proxy request handler instead of being done in the proxy manager. This can guarantee it gets done after the POM is downloaded, whereas this technique I think will fail if the POM was not already present. Can you review the patch? Thanks! If you could submit a single diff file for the proxy module that would be most helpful. > when used as a maven1 proxy, Archiva should handle relocation from maven2 poms > ------------------------------------------------------------------------------ > > Key: MRM-153 > URL: http://jira.codehaus.org/browse/MRM-153 > Project: Archiva > Issue Type: Improvement > Environment: Archiva as a repository proxy for maven1 > Reporter: nicolas de loof > Priority: Minor > Attachments: DefaultProxyManager.java.patch, > DefaultProxyManager.java.patch, MRM-153-test.patch, patch.patch > > > When a maven1 client asks for /servletapi/jars/servletapi-2.4.jar, Archiva > converts path to the maven2 location of this artifact. As maven1 has no > relocation support, the jar is required in the repo. > Archiva can be more that a proxy : download the artifact POM, read relocation > infos, and return the relocated jar. > attached Patch add a new "applyRelocation" to DefaultProxyManager. > I've tried this code with the servletapi example, but it may be bad designed > as I just discovered maven / archiva APIs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
