[ 
https://issues.apache.org/jira/browse/MENFORCER-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511603#comment-14511603
 ] 

Paul Vonnahme commented on MENFORCER-194:
-----------------------------------------

I believe transitive dependencies / project.getArtifacts() was broken in 1.3.1 
and greater by the fix put in for MENFORCER-156.  See my comment: 
https://issues.apache.org/jira/browse/MENFORCER-156?focusedCommentId=14511599&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14511599



> Rule RequireSameVersions: dependency artifacts are not checked
> --------------------------------------------------------------
>
>                 Key: MENFORCER-194
>                 URL: https://issues.apache.org/jira/browse/MENFORCER-194
>             Project: Maven Enforcer Plugin
>          Issue Type: Bug
>          Components: Standard Rules
>    Affects Versions: 1.3.1
>            Reporter: Rod Woo
>         Attachments: RequireSameVersions_setDependencies.patch
>
>
> In RequireSameVersions.java you must prefer the method 
> project.getDependencyArtifacts() to project.getArtifacts().
> Testcase and patch are attached.
> Furthermore, the official documentation of the rule should make clear that 
> transitive dependencies are not considered. This will make the rule for many 
> users meaningless.
> Furthermore, the official documentation of the rule should make clear that 
> the test coverage of the rule implementation is small.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to