[ http://jira.codehaus.org/browse/MCLOVER-50?page=comments#action_73031 ] 
            
Vincent Massol commented on MCLOVER-50:
---------------------------------------

Hi Andrew,

I've checked how they did it for covertura and that's the same way I've been 
trying to do it for Clover when I posted my answer above. However I believe 
this way is flawed. They've done it by introducing the following in the custom 
lifecycle.xml file:

{code:xml}
      <phase>
        <id>test</id>
        <configuration>
          
<classesDirectory>${project.build.directory}/generated-classes/cobertura</classesDirectory>
          <testFailureIgnore>true</testFailureIgnore>
          <forkMode>once</forkMode>
        </configuration>
      </phase>
{code}

There are 3 issues here:
* It won't work if the user has bound the surefire test goal to some other 
phase. For example it won't work for integration tests running in the 
integration-test phase.
* It's dangerous. Any plugin using the <testFailureIgnore> configuration 
property will find it modified to true even if that's not the expected 
behavior. We need some namespace here (I've just sent an email to the dev list 
on this topic)
* It'll only work for the surefire plugin but not for any other plugin such as 
checkstyle, pmd or any other custom plugin not known by the cobertura plugin. 
Thus it can only be a limited solution.

I'm open to ideas.

> Test failure during Site goal should not stop the Clover build
> --------------------------------------------------------------
>
>                 Key: MCLOVER-50
>                 URL: http://jira.codehaus.org/browse/MCLOVER-50
>             Project: Maven 2.x Clover Plugin
>          Issue Type: Bug
>    Affects Versions: 2.2
>            Reporter: Andrew Perepelytsya
>         Assigned To: Vincent Massol
>            Priority: Critical
>
> This problem is similar to whatever surefire-report plugin experienced up 
> until recently. Clover plugin runs tests in its own lifecycle. If there was a 
> test failure, the build should continue and site be generated with failure 
> reports. At the moment the build is stopped with a failure completely, and 
> site *not* generated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to