[ http://jira.codehaus.org/browse/MSITE-45?page=comments#action_72708 ] 
            
Vincent Siveton commented on MSITE-45:
--------------------------------------

Thanks Matthew!

Here my comments:
* adding a new dependency as plexus-archiver should be include in the patch
* calling mvn clean site:jar seems to not work. Should be better that 
SiteJarMojo extends SiteMojo instead of AbstractSiteMojo and using 
super.execute() if outputDirectory doesnt exist.
* please read [1] for the Maven's codestyle and how to create patch

[1] http://maven.apache.org/guides/development/guide-m2-development.html


> abilitiy to create an ear/war/zip from site
> -------------------------------------------
>
>                 Key: MSITE-45
>                 URL: http://jira.codehaus.org/browse/MSITE-45
>             Project: Maven 2.x Site Plugin
>          Issue Type: Bug
>            Reporter: Brett Porter
>         Attachments: patch.txt
>
>
> I think they should be standalone goals, like in m1
> site:ear -> create ear
> site:war -> create war
> site:zip -> create zip
> I think this one might be a lower priority. I will postpone it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to