[ http://jira.codehaus.org/browse/MECLIPSE-138?page=comments#action_71045 ] Andrew Perepelytsya commented on MECLIPSE-138: ----------------------------------------------
Current version uses a number of if-else statements for handling Eclipse, WTP (several versions). Add WSAD here and you now see only those if/else blocks. Yes, it would be nice to encapsulate those, but that is a broader scope, I doubt that would be done in short-term. But this quick-fix at least makes sure an intended internal user will not have to fiddle with forked plugins and custom repositories. A large portion of the task can be performed by opening those fillXXX methods already, and providing access to the constants. I would be more than happy to adjust if a deeper refactoring is performed ;) > Design Plugin classes for extension > ----------------------------------- > > Key: MECLIPSE-138 > URL: http://jira.codehaus.org/browse/MECLIPSE-138 > Project: Maven 2.x Eclipse Plugin > Issue Type: Improvement > Affects Versions: 2.3 > Reporter: Andrew Perepelytsya > > Please, replace all private access and methods in plugin classes with > protected. I'm trying to create a WSAD plugin by reusing (and subclassing) a > number of pure-Eclipse plugin classes, but it's impossible to accomplish > without changing the original sources. > Doing this will simplify contributions. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
