[ http://jira.codehaus.org/browse/MCHECKSTYLE-51?page=comments#action_71016 ] Olivier Vierlinck commented on MCHECKSTYLE-51: ----------------------------------------------
I put the same king of javadoc as in the existing code. Anything more needed? Regarding the example, what should I do? I don't see example in the existing code? if this patch is accepted, I don't mind editing the Customization page on maven.apache.org or provide a patch for this page (note that other existing features are not yet listed on this page either: enableRulesSummary, enableFileSummary,...) OK for unit test, I could change the sample rule definition to add a rule that is satisfied and test that when 'showNonViolatedRules' is false, it is not shown For the 'sorting' feature, I don't know if unit test is relevant.. or more relevant for this feature than for any other non-unit-tested checkstyle features... Let me know what to do from here... > Rules summary flexibility:add possibility to hide non-violated rules and to > sort by descending number of occurences > ------------------------------------------------------------------------------------------------------------------- > > Key: MCHECKSTYLE-51 > URL: http://jira.codehaus.org/browse/MCHECKSTYLE-51 > Project: Maven 2.x Checkstyle Plugin > Issue Type: Improvement > Affects Versions: 2.1 > Environment: NA > Reporter: Olivier Vierlinck > Priority: Minor > Attachments: MNG-39787-maven-plugin-checkstyle.patch > > > While using maven + Checkstyle on a new project, the amount of > errors/warnings was quite high, due both because checkstyle was not yet > configured to match our preferences.. and also to real style errors. > To refine this, it very useful to tackle first the big problems=the one > occuring often > Similarly, it is helpful NOT to see the rules that are not violated, so that > we can concentrate on the existing problems -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
