[ http://jira.codehaus.org/browse/MPFAQ-20?page=comments#action_70540 ] 
            
Arnaud Heritier commented on MPFAQ-20:
--------------------------------------

I found the following usages of x:forEach without a var attribute :

plugins\changes\src\plugin-resources\changes.jsl(37):                 
<x:forEach select="head/*">
plugins\changes\src\plugin-resources\changes.jsl(55):                     
<x:forEach select="release">
plugins\changes\target\classes\plugin-resources\changes2rss.jsl(55):            
   <x:forEach var="action" select="//[EMAIL 
PROTECTED]'${pom.currentVersion}']/action">
plugins\checkstyle\src\plugin-resources\checkstyle-summary.jsl(32):       
<x:forEach select="//error" sort="@message">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(86):             
<x:forEach select="//[EMAIL PROTECTED]'error']" sort="@count" descending="true">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(101):             
<x:forEach select="//[EMAIL PROTECTED]'warning']" sort="@count" 
descending="true">
plugins\checkstyle\src\plugin-resources\checkstyle.jsl(116):             
<x:forEach select="//[EMAIL PROTECTED]'info']" sort="@count" descending="true">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(89):     
<x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(101):     
<x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(116):     
<x:forEach select="tag" sort="@name">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(141):     
<x:forEach select="$libraries" sort="@uri">
plugins\jellydoc\src\plugin-resources\maven-jellydoc-plugin.jelly(143):       
<x:forEach select="tag" var="tag" sort="@name">

Do you think that we have to fix them ?
All others x:forEach have this attribute.

And I found in several plugins the comment :
<!-- x:forEach is busted -->

> Faq plugin 1.6 does not work with upgraded dependencies for Maven-1.1-beta-3
> ----------------------------------------------------------------------------
>
>                 Key: MPFAQ-20
>                 URL: http://jira.codehaus.org/browse/MPFAQ-20
>             Project: maven-faq-plugin
>          Issue Type: Bug
>            Reporter: Lukas Theussl
>         Assigned To: Lukas Theussl
>             Fix For: 1.6.1
>
>
> After our various dependency upgrades (jelly, dom4j, jaxen, xerces...), the 
> faq plugin 1.6 does not process fml files correctly if they contain more than 
> one <part> section. Not sure what exactly causes it, but it gets fixed by 
> using a 'var' parameter in the x:forEach loop over different parts.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to