[ http://jira.codehaus.org/browse/MSUREFIRE-145?page=comments#action_69382 ]
Brett Porter commented on MSUREFIRE-145: ---------------------------------------- thanks for clarifying, so regarding these 2 points: 1) I was trying to explain that this was intentional. system properties set in the surefire plugin will not be used by the forked jvm (since it is forked in surefirebooter, not before the plugin executes). Instead, the system properties are passed into the booter (via fork configuration) so that they can be set inside the new VM. This clearly works in some circumstances, as my testcase showed (always is equivalent to pertest, howeverI checked them both) So (2) highlights that there is some problem, and I can't see it from the POM you gave (possibly inheritence is related to it). It will require more investigation, so I'm leaving this open. > Plugin not longer sets system properties when forking is on and debugging > information is not correct > ---------------------------------------------------------------------------------------------------- > > Key: MSUREFIRE-145 > URL: http://jira.codehaus.org/browse/MSUREFIRE-145 > Project: Maven 2.x Surefire Plugin > Type: Bug > Versions: 2.2 > Reporter: Vincent Massol > Priority: Blocker > > > The following code is in SurefirePlugin.java: > {code:java} > processSystemProperties( !fork.isForking() ); > if ( getLog().isDebugEnabled() ) > { > showMap( systemProperties, "system property" ); > } > {code} > 2 problems: > 1) fork.isForking() is false when forking is enabled and thus system > properties are not set: > {code:java} > protected void processSystemProperties( boolean setInSystem ) > { > [...] > if ( setInSystem ) > { > // Add all system properties configured by the user > Iterator iter = systemProperties.keySet().iterator(); > while ( iter.hasNext() ) > { > String key = (String) iter.next(); > String value = systemProperties.getProperty( key ); > System.setProperty( key, value ); > } > } > } > {code} > 2) showMap() is called regardless of whether the system properties are set > or not, leading to the following kind of misleading logs: > {noformat} > [...] > [DEBUG] Setting system property [cargo.jetty4x.port]=[8280] > [DEBUG] Setting system property [cargo.jetty6x.port]=[8280] > [DEBUG] Setting system property [cargo.jetty5x.port]=[8280] > [...] > {noformat} > Those properties are actually NOT set. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
