[ http://jira.codehaus.org/browse/MJAR-42?page=comments#action_67235 ] 

Brett Porter commented on MJAR-42:
----------------------------------

- default values should be given with default-value instead of an initialising 
value (the basedir won't be correctly aligned otherwise)
- this technique won't work especially well with multiple modules projects
- I'm not sure we want the Apache-specific NOTICE file in here. Perhaps it 
should be a part of the license specification.

Isn't a better workaround just to use the <resources> mechanism for this?

> Add LICENCE and NOTICE files to the jar
> ---------------------------------------
>
>          Key: MJAR-42
>          URL: http://jira.codehaus.org/browse/MJAR-42
>      Project: Maven 2.x Jar Plugin
>         Type: Improvement

>     Versions: 2.1
>     Reporter: Jeremy Boynes
>  Attachments: mvn-jar-patch.txt
>
>
> Patch attached that adds project LICENSE and NOTICE files into the output 
> jar. By default it will add LICENSE.txt and NOTICE.txt files from the 
> project's basedir (if they are present) into the META-INF directory of the 
> jar.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to