[ http://jira.codehaus.org/browse/MASSEMBLY-103?page=comments#action_67151 
] 

Richard van der Hoff commented on MASSEMBLY-103:
------------------------------------------------

The compile-time error is due to source files which have been deleted... 
They're reduced to zero size by the patch, but not removed. Try:

$ find src/main/java -name *.java -size 0 | xargs rm

Regarding the patch problem; there have been a few changes to 
AssemblyMojoTest.java since I made that patch, but it still applies fine for me:

$ svn co 
http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-assembly-plugin 
maven-assembly-plugin-trunk
...
$ cd maven-assembly-plugin-trunk
$ patch -p1 < ~/tmp/maven-assembly-plugin-filters.v2.patch 
patching file 
src/test/java/org/apache/maven/plugin/assembly/AssemblyMojoTest.java
Hunk #1 succeeded at 286 (offset 3 lines).
patching file src/test/plugin-configs/assembly/depSet-filter-plugin-config.xml
patching file src/test/resources/assemblies/dependencySet-filter.xml
patching file src/main/mdo/component.mdo
patching file src/main/mdo/descriptor.mdo
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/AssemblyExcludesArtifactFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/ArtifactMatchFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/CompoundArtifactFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/AssemblyIncludesArtifactFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/AssemblyScopeArtifactFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/filter/BaseArtifactFilter.java
patching file 
src/main/java/org/apache/maven/plugin/assembly/AbstractAssemblyMojo.java
patching file 
src/test/java/org/apache/maven/plugin/assembly/filter/ArtifactMatchFilterTest.java


> More powerful includes/excludes stuff in DependencySets in descriptors
> ----------------------------------------------------------------------
>
>          Key: MASSEMBLY-103
>          URL: http://jira.codehaus.org/browse/MASSEMBLY-103
>      Project: Maven 2.x Assembly Plugin
>         Type: New Feature

>     Versions: 2.1
>     Reporter: Richard van der Hoff
>  Attachments: maven-assembly-plugin-filters.patch, 
> maven-assembly-plugin-filters.v2.patch
>
>
> A couple of other issues - http://jira.codehaus.org/browse/MASSEMBLY-90, 
> http://jira.codehaus.org/browse/MASSEMBLY-41 - have pointed out the need for 
> more powerful filtering of dependency sets in assembly descriptors. I wanted 
> to take this further, so as to allow quite powerful boolean expressions for 
> the description of dependencies. For example, the assembly extract below will 
> include anything which is not a "zip" in the org.apache.maven.* or 
> org.codehaus.* groups.
> The attachment contains an implementation of this, and a couple of testcases 
> for the new functionality.
> <dependencySet>
>   <filter>
>     <negate>false</negate>
>     <subfilters>
>       <filter>
>         <matchAll>false</matchAll>
>         <matchers>
>           <matcher>
>             <group>org.apache.maven.*</group>
>           </matcher>
>           <matcher>
>             <group>org.codehaus.*</group>
>           </matcher>
>         </matchers>
>       </filter>
>     </subfilters>
>     <matchers>
>       <matcher>
>         <type>zip</type>
>       </matcher>
>     </matchers>
>   </filter>
> </dependencySet>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to