[ http://jira.codehaus.org/browse/MJAR-38?page=comments#action_66531 ]
Mike Perham commented on MJAR-38: --------------------------------- Jochen, please supply patches which are diff'd off the svn source. Your patches are based off of files with weird names (/tmp/MavenArchiver.java.1???) and can't be applied to SVN. Couple other comments: 1) There's a one or two places where your code doesn't match the Maven style. Please correct if possible. 2) Collections.EMPTY_MAP is immutable AFAIK. It's not clear to me if this Map will be mutated. Please replace it with new HashMap() if the contents are mutable. 3) in your third patch, you do "if containsKey remove". It'd rather see "if containsKey return" as it minimizes redundant work. > Maven Puts Arbitrary Extension Definition in JAR Manifest by Default. > --------------------------------------------------------------------- > > Key: MJAR-38 > URL: http://jira.codehaus.org/browse/MJAR-38 > Project: Maven 2.x Jar Plugin > Type: Bug > Versions: 2.0 > Environment: Maven version: 2.0.4 > Microsoft Windows XP [Version 5.1.2600] > Reporter: Steven Coco > Attachments: Jar Extension-Name Tester.zip, MavenArchiver.patch.1, > MavenArchiver.patch.2, MavenArchiver.patch.3 > > > I'm using the latest Maven release. When I build my project, the > resulting Jar file's manifest contains an Extension-Name attribute along with > Specification and Implementation attributes. The POM contains no mention > that this project is a Java optional package -- an "extension" (or an > extension of any other kind). > I don't know why Maven is doing that. > If Maven is doing this by default for some reason, it absolutely > shouldn't. Maven should not identify my Jar as an optional package unless I > explicitly say so. Jars are only extensions if explicitly created as such. > The name it uses for the extension name is the POM's <artifactId>. > That's not even a UID! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
