[ http://jira.codehaus.org/browse/MNGECLIPSE-59?page=comments#action_63914 
] 

Dimitry Voytenko commented on MNGECLIPSE-59:
--------------------------------------------

Hi Mark,

I managed to recompile and run the plugin. It works well. But there were couple 
issues I ran into:

1) It still crashes inside of Maven2Plugin.getWorkspaceNature() for 
"project.getNature" when project is closed. I added check for project's 
closed/open status - it was fine.
2) Just to be aware, you had "libraryEntries.add(JavaCore.newProjectEntry(...)" 
inside of the if with "("jar".equals(a.getType()) || "zip".equals( a.getType() 
)" which was since changed to "artifactLocation.endsWith("jar") || 
artifactLocation.endsWith("zip")". For the obvious reasons your code for adding 
project to the classpath is never called now (since location is "pom.xml" in 
that case). I had to move it outside of plugin, it was fine as well.


> Allow artifact resolution from workspace projects
> -------------------------------------------------
>
>          Key: MNGECLIPSE-59
>          URL: http://jira.codehaus.org/browse/MNGECLIPSE-59
>      Project: Maven 2.x Extension for Eclipse
>         Type: New Feature

>   Components: Dependency Resolver
>     Versions: 0.0.4
>     Reporter: Leonardo Quijano Vincenzi
>     Assignee: Eugene Kuleshov
>      Fix For: 1.0.0
>  Attachments: ArtifactResolver-try3.patch, 
> EclipseArtifactResolver-corrected.patch, EclipseArtifactResolver.patch, 
> maven-embedder-2.1-SNAPSHOT-dep.jar
>
>
> Provide artifact resolution from workspace projects, which override the same 
> artifact from the local or remote repositories. This would allow to work with 
> dependant Eclipse projects without specifying the Eclipse dependency manually.
> The workspace artifact resolution would have to be specified manually, since 
> several Maven-Enabled projects in the same workspace could have the same 
> artifact and version Id. Or at least automatic resolution with an optional 
> override would be nice.
> More comments here:
> http://jira.codehaus.org/browse/MNGECLIPSE-58

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to