[ http://jira.codehaus.org/browse/MPJUNITREPORT-2?page=all ] Lukas Theussl closed MPJUNITREPORT-2: -------------------------------------
Assign To: Lukas Theussl Resolution: Fixed The html escaping issues has been fixed as part of MPJUNITREPORT-3, I have added additional <pre> elements inside source to address the second point. > formatting/escaping of error messages > ------------------------------------- > > Key: MPJUNITREPORT-2 > URL: http://jira.codehaus.org/browse/MPJUNITREPORT-2 > Project: maven-junitreport-plugin > Type: Bug > Environment: maven rc1, maven-junit-report-plugin-1.3 > Reporter: fabrizio giustina > Assignee: Lukas Theussl > Priority: Critical > Fix For: 1.5.1 > > > error details and stacktraces in junit report can be unreadable. There are > multiple problems in the formatting: > - error details in the original junit output are already xml-escaped. In > junit.jsl are again html-escaped > (${htmlescape.getText(current.attribute('message').value)}) so < %gt; will > be escaped 2 times! Text should not be escaped again but put in a CDATA > section (or unescaping xml before escaping html) > - newlines are not preserved. Reading stacktraces is really hard! Test should > be wrapped in <pre>, not in <code> > - lots of whitespaces and newlines are added, also inside comment (usually > around all [ ] < > / characters). This could also make the message loose all > its meaning, say > Error: expected value = "[2][2]" actual = "[2] [2 ]" > can become: > Error : expected value = " [ 2 ] [ 2 ] " actual = " [ 2 ] [ 2 ] ". > This is a common problem with jellyscript, but should be avoided wrapping > text in cdata before the jsl transformation > see the jtidy maven site for an example of unreadable report: > http://jtidy.sourceforge.net/junit-report.html -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira