Bad algorithm to decide if the main artifact is to be installed or not
----------------------------------------------------------------------

         Key: MINSTALL-18
         URL: http://jira.codehaus.org/browse/MINSTALL-18
     Project: Maven 2.x Install Plugin
        Type: Bug

    Versions: 2.1    
    Reporter: Vincent Massol


Here' s what's in InstallMojo's execute method:

{code}
                // Here, we have a temporary solution to MINSTALL-3 
(isDirectory() is true if it went through compile
                // but not package). We are designing in a proper solution for 
Maven 2.1
                if ( file != null && !file.isDirectory() )
                {
                    installer.install( file, artifact, localRepository );
                }
                else if ( !attachedArtifacts.isEmpty() )
                {
                    getLog().info( "No primary artifact to install, installing 
attached artifacts instead." );
                }
{code}

This fails if we're building a JAR with no sources but with an attached 
artifact and only the attached artifact is created (this is the case when using 
the clover plugin). In that case, the install mojo tries to install the main 
artifact which doesn't exist).

The error is in "!file.isDirectory". In the case of a jar with no sources, this 
directory will not have been created...



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to