DefaultContinuumScm.getScmRepository should not set project scm 
username/password if they are the empty string
--------------------------------------------------------------------------------------------------------------

         Key: CONTINUUM-651
         URL: http://jira.codehaus.org/browse/CONTINUUM-651
     Project: Continuum
        Type: Bug

  Components: Core system  
    Reporter: John Didion


Should be using StringUtils.isEmpty instead of doing a null check.

{noformat}
if ( !StringUtils.isEmpty(project.getScmUsername()) )
{
    providerRepository.setUser( project.getScmUsername() );

    if ( project.getScmPassword() != null )
    {
        providerRepository.setPassword( project.getScmPassword() );
    }
    else
    {
        providerRepository.setPassword( "" );
    }
}
{noformat}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to