[ http://jira.codehaus.org/browse/MASSEMBLY-56?page=comments#action_61007 ]
John Casey commented on MASSEMBLY-56: ------------------------------------- What about naming it something like "directory-in-lifecycle" or something. I know it's an ugly name, but it's not like this is something people should be typing on the command line...in fact, it's designed *not* to be used from the command line. I think the important thing with the name is that it shouldn't reflect anything about attachment, since the attachment isn't really the defining factor for separating this from the normal :directory mojo...instead, maybe it should reflect the fact that it's meant to run as part of a lifecycle, rather than on its own. Come to think of it, perhaps we should rename the assembly:attached mojo to reflect this same thing, since I think the use case is the same. As for whether we need this mojo or not, my only concern is that the assembly:directory mojo might launch a forked lifecycle that would run up to the 'package' phase if it were bound directly into the lifecycle itself. This would be pretty inefficient, since what you really want is to tell Maven that the prerequisites for this mojo will be filled during the course of the normal lifecycle. *Is* it the case that the :directory mojo would fork a new lifecycle if it were bound to the 'package' phase? I *think* the infinite looping should be fixed by now, possibly as late as the 2.0.3 code. If this mojo doesn't fork a new lifecycle, then we shouldn't bother creating the mojo described by this issue; it's a moot point. > Refactor DirectoryMojo so it can be run either stand-alone or attached > ---------------------------------------------------------------------- > > Key: MASSEMBLY-56 > URL: http://jira.codehaus.org/browse/MASSEMBLY-56 > Project: Maven 2.x Assembly Plugin > Type: Improvement > Versions: 2.1 > Reporter: John Didion > Fix For: 2.1 > Attachments: MASSEMBLY-56.patch > > > Pretty straight-forward. Just make the directory goal into two goals (like > assembly and attached), one that can be run stand-alone and one that can be > run attached to a lifecycle phase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
