[ http://jira.codehaus.org/browse/MNG-2136?page=comments#action_60671 ] 

John Casey commented on MNG-2136:
---------------------------------

Alright, let's see if we can make <activeByDefault/> a little more intuitive. 
Since external profiles (from profiles.xml or settings.xml) may be injected at 
almost any time (especially those in settings.xml), we don't want them to 
factor into the calculation of whether "by default" is satisfied...in other 
words, we don't expect/want that external profiles will have an impact on 
whether a default profile is used or not. The only thing that should be able to 
suppress a profile that's active-by-default is another profile in the POM which 
has been activated, either explicitly or using some trigger.

Using this, your example can still have users supplying installation 
directories for containers in an external profile (though the settings.xml may 
be a better place for this...I dunno). When they specify an install dir through 
a profile, that will have no impact on the choice of container to be installed, 
which is specified by a set of profiles that are embedded in the POM. When the 
user triggers some other container, maybe by "-Dcontainer=orion" or something, 
then the default profile of "jboss4" will be suppressed in favor of the "orion" 
profile...both of these would be embedded in the POM.

I'm checking this change into SVN soon, and we can roll it back if need be. IT 
is it0102 for testing purposes. Let me know what you think.

> Active profile in profiles.xml prevents active profile in pom.xml to be 
> triggered automatically
> -----------------------------------------------------------------------------------------------
>
>          Key: MNG-2136
>          URL: http://jira.codehaus.org/browse/MNG-2136
>      Project: Maven 2
>         Type: Bug

>   Components: POM
>     Versions: 2.0.3
>     Reporter: Vincent Massol
>     Assignee: John Casey
>     Priority: Blocker
>      Fix For: 2.0.3

>
>
> If there's a profiles.xml with an active profile in it, then the active 
> profile defined in the pom.xml is ignored and not triggered.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to