sgup432 commented on PR #16757: URL: https://github.com/apache/lucene/pull/16757#issuecomment-6276641571
@kkewwei Thanks for this change, a must needed but I have few questions/comments on how it is implemented: 1. Firstly, I think it would be better to introduce the API on the base class ie DocIdStream so other implementation can override if they want. Keeping per doc evaluation as default. Also having naming the API as something like `intoBitSet` similar to what we have in `DocIdIterator`. 2. Secondly, I see all the other APIs on DocIdStream have two variants, with and without `upTo` parameter where the caller can either collect all docs at once or maybe split it depending on the usecase. `intoBitSet(int upTo, FixedBitSet bitSet, int offset)` I would like to get opinions from others on this as to what they think. @romseygeek Can you help here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
